Comments on: Timing JSF Requests Using a Phase Listener

By: Dmtiri

Dmtiri — Sat, 26 Mar 2011 15:02:53 +0000

better will be like this
public void afterPhase(PhaseEvent event) {
12 if (!log.isDebugEnabled()) return;
09 if (event.getPhaseId() == PhaseId.RENDER_RESPONSE) {
10 long endTime = System.nanoTime();
11 long diffMs = (long) ((endTime – startTime) * 0.000001);
13 log.debug(“Execution Time = ” + diffMs + “ms”);
15 }
17 log.debug(“Executed Phase ” + event.getPhaseId());
19 }

By: Andy Gibson

Andy Gibson — Thu, 20 Jan 2011 04:43:56 +0000

Hey Daniel,

Yes, you are correct, this isn’t thread safe which I don’t worry about since I never deploy this into production. I just use it for development to see when I wrote some code that is slow. You could pop the timestamp into the session and read it back in when the phase is complete.

Cheers,

Andy Gibson

By: Camilo Correa

Camilo Correa — Tue, 18 Jan 2011 19:28:52 +0000

Agree with @Daniel… just one instance of listener. Just use this solution in a controlled envirnonment… never as diagnostic tool in production

By: Daniel

Daniel — Thu, 16 Dec 2010 10:43:39 +0000

Hi, isn’t there only one instance of this and shared accross all users and requests which would then mean that the private field startTime will be overwritten with each request?

By: Andy Gibson

Andy Gibson — Tue, 20 Jul 2010 23:53:00 +0000

This implementation does time the whole lifecycle from restore view to the completion of the rendering. Reading back the post, it does say it logs the end of each phase, but it only writes out the the log file the end of each phase.

Cheers,

Andy Gibson

By: Thiago

Thiago — Tue, 20 Jul 2010 13:11:22 +0000

I have a question, what if I want to log the total time spent to process all the phases, not the current one? What could be done to achieve this?

By: nmatrix9

nmatrix9 — Mon, 25 Jan 2010 02:12:04 +0000

It looks very useful, thanks!